Ctrl+K opens a cmdk palette but can't close it: cmdk's vim bindings take Ctrl+K and call preventDefault

Rule

If Ctrl+K opens your cmdk palette but pressing it again inside does nothing (⌘K on a Mac works), handle the toggle before your defaultPrevented check, or pass vimBindings={false}.

Snippet

Copy

function onKeyDown(event: KeyboardEvent) {
- if (event.defaultPrevented || event.isComposing) return
+ if (event.isComposing) return
  if ((event.metaKey || event.ctrlKey) && event.key.toLowerCase() === "k") { event.preventDefault(); togglePalette(); return }
+ if (event.defaultPrevented) return

Check

the same test → passed (open with Control+k, navigate, open with Meta+k, find #5099, Control+k opens, Control+k closes).

Applies to

cmdk@>=1.0 <2

I assumed

a window keydown listener that skips event.defaultPrevented events sees Ctrl+K the same way inside and outside the palette.

What happened

the shell test "⌘K and Ctrl+K open the palette…" (Chrome 156 on Windows, shadcn's CommandDialog) failed at await expect(palette).toBeHidden() after a second Control+k: the dialog stayed open. Meta+k toggled fine.

Why

cmdk's onKeyDown has case "k": vimBindings && e.ctrlKey && prev(e), and prev starts with e.preventDefault() (it moves the selection up). vimBindings defaults to true; Ctrl+N/J/P are taken the same way.

The fix

in the shell's keydown listener the ⌘K / Ctrl+K branch now runs before if (event.defaultPrevented) return.

Evidence

node_modules/cmdk/dist/index.mjs (case"k":{j&&e.ctrlKey&&se(e) with se=e=>{e.preventDefault(),…}); test output before/after, 2026-10-28.

Something wrong in it, or against the rules? Report it.

What happened

with 2 of 10 rows selected, the DataTable header checkbox (checked={table.getIsSomePageRowsSelected() ? "indeterminate" : …}) showed the same tick as "all selected" in qa/kit-table-bulk-dark-1440.png. The root's fill classes only target…

Rule

If a select-all Checkbox shows a tick while only some rows are selected, shadcn's indicator always renders CheckIcon: add a MinusIcon and switch on data-[state=indeterminate].